Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): exclude .dockerignore from context hash #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ethanwu10
Copy link
Member

Since .dockerignore is a means to control what is in the build context, the contents of the file itself should not be included in the context hash. See #117 for more details.

Closes #117

Since `.dockerignore` is a means to control what is in the build
context, the contents of the file itself should not be included in the
context hash. See #117 for more details.

Closes #117
@ethanwu10 ethanwu10 added component/core kind/bug Something isn't working labels Feb 27, 2021
@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #126 (db0fb48) into master (2107b0a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files          27       27           
  Lines         990      990           
  Branches      167      167           
=======================================
  Hits          601      601           
  Misses        375      375           
  Partials       14       14           
Impacted Files Coverage Δ
rcds/challenge/docker.py 87.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2107b0a...db0fb48. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.dockerignore is included in build context hash
1 participant