Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3090] Reduce Command Responses in Redis Connection Process (on_connect) #3268

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[#3090] Reduce Command Responses in Redis Connection Process (on_connect) #3268

wants to merge 14 commits into from

Commits on Jun 13, 2024

  1. refactor: Improve HELLO command handling with auth args for Redis 6.0… 

    … and above, using MULTI command as a fallback
    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a7bab19 View commit details
    Browse the repository at this point in the history

  2. refactor: Add commands for setting client name, library info, databas… 

    …e selection, and client caching
    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0e9b8cb View commit details
    Browse the repository at this point in the history

  3. feat: Add handling for MULTI block execution with AUTH response check… 

    … and error handling
    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    6909d23 View commit details
    Browse the repository at this point in the history

  4. feat: Add error handling for EXEC command response with retry logic c… 

    …onsideration
    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    72292f9 View commit details
    Browse the repository at this point in the history

  5. feat: add response handling for various client commands with detailed… 

    … error checks
    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0cd59b8 View commit details
    Browse the repository at this point in the history

  6. test: test for on_connect to verify correct command sequence and resp… 

    …onses connection
    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    3a6cb1e View commit details
    Browse the repository at this point in the history

  7. test: test for on_connect to handle HELLO command failure

    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    7754937 View commit details
    Browse the repository at this point in the history

  8. test: test for on_connect to handle AUTH failure

    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    2121304 View commit details
    Browse the repository at this point in the history

  9. test: Test password-only AUTH for Redis versions below 6.0.0 without … 

    …HELLO command
    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    b16868f View commit details
    Browse the repository at this point in the history

  10. refactor: Add AUTH command to send_command based on Redis version che… 

    …ck if no exceptions occur.
    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    241e119 View commit details
    Browse the repository at this point in the history

  11. refactor: MULTI and subsequent commands

    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    e6af1f4 View commit details
    Browse the repository at this point in the history

  12. refactor: Modify code to execute the EXEC command within the try bloc… 

    …k where the MULTI command is executed.
    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    1d4c679 View commit details
    Browse the repository at this point in the history

  13. fix: Remove redundant AUTH command check logic as similar logic exist… 

    …s (lines 461-468).
    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    eae6d46 View commit details
    Browse the repository at this point in the history

  14. fix:Remove the condition that checks for connection retries 

    This update eliminates the condition checking for connection retries because the logic was refactored to execute MULTI and EXEC commands within the same try block. This adjustment resolves the issue with unintended reconnection attempts, ensuring proper handling of transactional commands
    @zeze1004
    zeze1004 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c4c21d0 View commit details
    Browse the repository at this point in the history