Bugfix/comprehensive index equality #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #494
#479 added support for checking the equality of the current state of your model in your code versus what is in Redis, however there are a number of cases it did not account for which I missed during my review (e.g Vector fields, the special arguments from text fields, special arguments in the Document Attribute) one of which someone tripped over in #494. This PR should address all of these.
There is still the special case where it will not be able to definitively tell whether or not a index definition matches as several fields from the index definition are not returned from FT.INFO, namely
STOPWORDS,PHONETIC,EF_RUNTIME,EPSILON, in which ase Redis OM will simply throw anArgumentException.