Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ballerina Redis client #2682

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Conversation

NipunaRanasinghe
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe commented Mar 8, 2024

This PR adds information on the Official Redis client library for Ballerina. This client comes with the support for Redis clusters, connection pooling and secure connections OOTB.

References

Copy link

netlify bot commented Mar 8, 2024

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 49d386c

@NipunaRanasinghe
Copy link
Contributor Author

NipunaRanasinghe commented Mar 11, 2024

@zuiderkwast @madolson Appreciate your review on this

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I don't know Ballerina, but that's my problem. :)

clients/ballerina/github.com/redis/ballerinax-redis.json Outdated Show resolved Hide resolved
@zuiderkwast zuiderkwast merged commit 5477705 into redis:master Mar 11, 2024
1 check failed
@NipunaRanasinghe
Copy link
Contributor Author

NipunaRanasinghe commented Mar 12, 2024

Seems fine to me. I don't know Ballerina, but that's my problem. :)

@zuiderkwast You're always welcome to try out this new programming language, [specialized in integration].(https://ballerina.io/usecases/integration/)

btw, thanks for your support on this. Can I know when we can expect these changes in the live site?

@zuiderkwast
Copy link
Contributor

Can I know when we can expect these changes in the live site?

It should be live automatically after it's merged. I just checked and it's not visible so I started wondering. I found languages.json. My guess is that we need to add Balleria there.

@zuiderkwast
Copy link
Contributor

I opened a PR but I realized I can't approve and merge my own PR. If you're in hurry, you can open another PR just like mine and I can approve and merge it.

@NipunaRanasinghe
Copy link
Contributor Author

I opened a PR but I realized I can't approve and merge my own PR. If you're in hurry, you can open another PR just like mine and I can approve and merge it.

I was creating the duplicate PR and then only realized someone else has approved your original one :D thanks for your time on this anyway

@zuiderkwast
Copy link
Contributor

Haha, sorry, I'm too impatient. :) Anyway, now it's live and Ballerina is visible.

@zuiderkwast
Copy link
Contributor

However, the link doesn't work. The URL is part of the filename clients/ballerina/github.com/redis/ballerinax-redis.json. It generates a link to github.com/redis/ballerinax-redis which is wrong. We need to rename/move the file.

Again, I didn't review this properly. Sorry for this.

Can you fix it in another PR?

@NipunaRanasinghe
Copy link
Contributor Author

NipunaRanasinghe commented Mar 12, 2024

However, the link doesn't work. The URL is part of the filename clients/ballerina/github.com/redis/ballerinax-redis.json. It generates a link to github.com/redis/ballerinax-redis which is wrong. We need to rename/move the file.

Again, I didn't review this properly. Sorry for this.

Can you fix it in another PR?

It seems both of us realized it at the same time 😃 I've been already working on it and just sent the PR fixing that.

Apologies for the mistake and appreciate your review on #2685

@zuiderkwast
Copy link
Contributor

Merged. Now the link works. Thanks!

@NipunaRanasinghe
Copy link
Contributor Author

NipunaRanasinghe commented Mar 12, 2024

Merged. Now the link works. Thanks!

Thanks again @zuiderkwast! btw I just noticed that additional information (e.g. the license, number of github stars) are not shown for the Ballerina client, even though I have correctly pointed out the repo link in the metadata. Do you have any idea on what might have gone wrong?

@zuiderkwast
Copy link
Contributor

I believe it's some cache. Let's wait 24h and see if it gets updated.

IIRC the website rendering code is in https://github.com/redis/redis-website if you want to investigate how it works.

@NipunaRanasinghe
Copy link
Contributor Author

NipunaRanasinghe commented Mar 14, 2024

I believe it's some cache. Let's wait 24h and see if it gets updated.

IIRC the website rendering code is in https://github.com/redis/redis-website if you want to investigate how it works.

@zuiderkwast As it's been more than 24 hours and the information still not updated, I believe there maybe something else gone wrong here 🤔 I had a look into https://github.com/redis/redis-website as well, but no luck so far.

In that case, is there anyone else from whom we can ask for help?

@zuiderkwast
Copy link
Contributor

@itamarhaber

@NipunaRanasinghe
Copy link
Contributor Author

@itamarhaber @zuiderkwast it's still the same. Really appreciate your support on this!

@zuiderkwast
Copy link
Contributor

@NipunaRanasinghe Redis® is no longer open source. I'm out.

Working on forking now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants