Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #886 #2630

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fixed #886 #2630

wants to merge 4 commits into from

Conversation

mich-elle-luna
Copy link
Collaborator

adds a couple of tips to EVAL doc about TTL and fixes a typo #886

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for redis-doc ready!

Name Link
🔨 Latest commit 9a7f9a4
🔍 Latest deploy log https://app.netlify.com/sites/redis-doc/deploys/658622b7b9dda70008734a04
😎 Deploy Preview https://deploy-preview-2630--redis-doc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

The script **should only** access keys whose names are given as input arguments.
Scripts **should never** access keys with programmatically-generated names or based on the contents of data structures stored in the database.
If a key with expiry (TTL) exists at the start of eval, it will not get expired during the evaluation of a script.
During the evaluation of a Lua script, TTL of a key can go down to zero. After that, it remains zero until the script terminates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? Can you give an example?

I thought that we freeze time during evaluation, so TTL will return the same value every time throughout the evaluation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yean, we will freeze the time during the evaluation, the [P]TTL should return the same value in this case in Redis 7.2

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The points listed in #886 are not valid anymore. This PR needs to explain the behaviour after redis/redis#10300 was merged, i.e. the time is frozen during script execution.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants