redisAsyncAppend family of commands #822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ hiredis.c: Convert redisSetError to take format and va_args
+ dict.* : Fixed generic hash function -> cannot really take signed number
+ async.* : Valdup function now handles OOM properly
KeyCompare function uses proper sized integers
nextArgument - change to use proper str-int conversion function
Added redisAsyncAppend* function family to support buffer
optimizations in async-mode
Added proper error handling on OOM errors [inc buffer rollback]
+ hiredis.c : Reverted back to memcpy(), will test *printf in different time + aysnc.c : Minor changes for better readability
Merging the nice redisAsyncAppend* functions into current hiredis master to fix conflicts.
oshamash
approved these changes
May 24, 2020
|
Closing in favor of #983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the redisAsyncAppend* family of commands and type fixes by @oshamash
See #638 for the original PR and discussion.