Test for both EAGAIN and EINPROGRESS for AF_UNIX sockets. #1262
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems unstable on macOS. It doesn't seem related to the commit because I get random failures on master as well. I will look into it though. It doesn't ever fail for me on a local mac. |
Reading the manpage it seems like we only need to test for `EAGAIN` but testing for both seems more prudent since this may be subtly different on more esoteric kernels (SunOS, AIX, BSD, etc). Fixes #1260
michael-grunder
force-pushed
the
minor-af_unix-fix
branch
from
e14cf21
to
03e23c6
Compare
yossigo
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Hi @michael-grunder, did you actually manage to reproduce this?
|
I wasn't able to replicate the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading the manpage it seems like we only need to test for
EAGAINbut testing for both seems more prudent since this may be subtly different on more esoteric kernels (SunOS, AIX, BSD, etc).Also explicitly install openSSL3 on macOS.
Fixes #1260