fix format string in command #1070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2022 11:30
|
command DEBUG SLEEP fix? run the tests again |
|
If you rebase your PR off of the current master I can rerun the tests. |
bjosv
reviewed
Sep 14, 2022
| goto fmt_valid; | ||
| } | ||
|
|
||
| /* String conversion (without modifiers) */ |
There was a problem hiding this comment.
One behavioral change of handling %s after flags/field/precision is that flags are now accepted for strings (like %+s), while before this was a format error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1069
Fix #1069