Cluster graviton savings to non-graviton instances #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ebattat
reviewed
Oct 9, 2024
| @@ -21,3 +21,31 @@ | |||
| EC2_NAMESPACE = 'AWS/EC2' | |||
| CLOUDWATCH_METRICS_AVAILABLE_DAYS = 14 | |||
| AWS_DEFAULT_GLOBAL_REGION = 'us-east-1' | |||
|
|
|||
There was a problem hiding this comment.
can we fetch it from AWS automatically and not use it manually ?
ebattat
reviewed
Oct 9, 2024
ebattat
reviewed
Oct 9, 2024
| @@ -54,6 +56,8 @@ def run_policy_operations(self): | |||
| else: | |||
| running_instances = 1 | |||
| creation_date = '' | |||
| rosa_cluster = True if self.get_tag_name_from_tags(tags=tags, tag_name='red-hat-managed') else False | |||
| using_graviton = True if '.g' in instance.get('InstanceType') else False | |||
There was a problem hiding this comment.
a1 is also graviton, is it good for cluster ?
athiruma
force-pushed
the
cluster_graviton_savings
branch
3 times, most recently
from
32692de
to
27fd96d
Compare
athiruma
commented
Oct 9, 2024
| instance_types_count = instance_types.count(instance_type) | ||
| unit_price = self._resource_pricing.get_ec2_price(region_name=self._region, | ||
| instance_type=instance_type) | ||
| total_cost += unit_price * 24 * running_hours * instance_types_count |
There was a problem hiding this comment.
unit_price * running_hours * instance_types_count
athiruma
force-pushed
the
cluster_graviton_savings
branch
from
27fd96d
to
15761ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Added the Gravtion savings, if the cluster is running the non-gravitation instances.
Description
For security reasons, all pull requests need to be approved first before running any automated CI