Fixed the name of the policy #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athiruma
force-pushed
the
fix_policy_name
branch
from
7b1b632
to
b660c91
Compare
ebattat
reviewed
Aug 30, 2023
| @@ -137,7 +136,7 @@ sudo podman run --rm --name cloud-governance -e policy="ec2_idle" -e AWS_ACCESS_ | |||
| # policy=ec2_run | |||
| sudo podman run --rm --name cloud-governance -e policy="ec2_run" -e AWS_ACCESS_KEY_ID="$AWS_ACCESS_KEY_ID" -e AWS_SECRET_ACCESS_KEY="$AWS_SECRET_ACCESS_KEY" -e AWS_DEFAULT_REGION="us-east-2" -e dry_run="yes" -e policy_output="s3://bucket/logs" -e log_level="INFO" "quay.io/ebattat/cloud-governance" | |||
|
|
|||
| # select policy ['ec2_stop', 's3_inactive', 'empty_roles', 'ip_unattached', 'nat_gateway_unused', 'zombie_snapshots'] | |||
| # select policy ['ec2_stop', 's3_inactive', 'empty_roles', 'ip_unattached', 'unused_nat_gateway', 'zombie_snapshots'] | |||
There was a problem hiding this comment.
Is that mean that this policy didnt run ?
There was a problem hiding this comment.
can u check the other policies name ?
There was a problem hiding this comment.
Pls let me know when u finish
There was a problem hiding this comment.
Yes, checked all are perfect. Good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Fixed the name of the policy.
For security reasons, all pull requests need to be approved first before running any automated CI