fix: disambiguate Quarkus launch config #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
reviewed
Sep 5, 2023
angelozerr
reviewed
Sep 5, 2023
src/main/java/com/redhat/devtools/intellij/quarkus/run/QuarkusRunConfiguration.java
Outdated
Show resolved
Hide resolved
fbricon
force-pushed
the
disambiguate-quarkus
branch
from
02e9992
to
7dcb264
Compare
Signed-off-by: Fred Bricon <[email protected]>
fbricon
force-pushed
the
disambiguate-quarkus
branch
from
7dcb264
to
40ed57f
Compare
|
SonarCloud Quality Gate failed.
|
|
Thanks @fbricon ! |
|
Not sure why Quarkus Dev Mode? |
|
because it's run configurations to launch Quarkus in dev mode |
|
ah ok 😅 I thought it was the plugin name .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the name of the Quarkus run configuration type to "Quarkus Dev Mode", to disambiguate from Intellij Ultimate's own config type.
Also fixed the dark mode icons, which unfortunately don't help with the confusion since they're identical to the ones used in Ultimate, but it's more correct now.
Partially fixes #1045