-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bumped schema to v1.25.3 (#501) #507
Conversation
Signed-off-by: Andre Dietisheim <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lstocchi, @jeffmaury: it's striking how much is removed with this bump: The explanation is that many deprecated items were removed. The details can be read in the deprecation guide at kubernetes.io: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25
One could wonder if we should support multiple schema. |
We should support several Kubernetes versions and not only the last one. |
@adietish What's the status of this PR ? Should we merge this to main ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still valid ?
The issue is, the PR isnt. The PR is badly incomplete. It is simply bumping the supported schema where support for multiple schema should be provided (not just the latest but query the cluster for supported ones and then provide a matching schema in the editor). |
fixes #501