Fixed linux powershell installation and execution #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… paths for Atomic Red Team **Added:** - Added variables for PowerShell version and installation path. - Included common, Debian-specific, and RedHat-specific package lists for installation. **Changed:** - Refactored PowerShell installation to use a generic approach with architecture mapping. - Updated `invoke-atomictest.yml` to use the `pwsh` command without absolute paths. - Simplified `setup-linux.yml` to streamline PowerShell setup and remove old installation methods. **Removed:** - Removed old PowerShell installation tasks specific to Ubuntu, Amazon Linux, and CentOS.
**Changed:** - Standardized variable names with `ansible_atomic_red_team_` prefix for consistency. - Updated `example-playbook.yml` to use the new standardized variable names. - Moved `update-art-tids.sh` script from `vars` to `files` directory and set executable permissions. - Enhanced `gather-art-tids.yml` task to create a temporary directory, copy the emergency bash script, and gather ART TIDs into a YAML file in the temporary directory. - Modified `invoke-atomictest.yml` to set a fact for `prereq_check_passed` and conditional execution of test and cleanup tasks based on this fact. - Updated `setup-linux.yml` to include installation of Invoke-ART, setting up the PowerShell profile, and added additional packages for setup. - Removed `update-art-tids.sh` script from `vars` directory as it has been moved to `files`. - Added a timeout variable `ansible_atomic_red_team_timeout` for ART tests in `defaults/main.yml`. **Removed:** - Removed unused variables `atomic_red_team_common_install_packages`, `atomic_red_team_debian_specific_packages`, and `atomic_red_team_redhat_specific_packages` from `vars/main.yml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role was not working for me in several linux distros, so I went ahead and fixed the issues I encountered.
I've also got working molecule tests, which I'm happy to provide in a separate PR.
Added:
Changed:
invoke-atomictest.ymlto use thepwshcommand without absolute paths.setup-linux.ymlto streamline PowerShell setup and remove old installation methods.Removed: