Upgrade Webpack & Sass #1679
Merged
Upgrade Webpack & Sass #1679
+778
−1,546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsomthd
requested review from
GowthamShanmugam,
SanjalKatiyar and
bipuladh
alfonsomthd
force-pushed
the
webpack-upgrade
branch
from
43469f4
to
3e7d828
Compare
alfonsomthd
force-pushed
the
webpack-upgrade
branch
from
3e7d828
to
2d05345
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alfonsomthd, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/odf-console-e2e-aws |
|
@alfonsomthd: Overrode contexts on behalf of alfonsomthd: ci/prow/odf-console-e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPGRADED:
webpackts-nodecrashing with unexpected errors, it has been replaced with simplertsx(works out-of-the-box).tsmhas been replaced bytsx(it was redundant).style-loaderis kept in 3.x due to v4 throwing unexpected errors.Sasssassdependency has been replaced withsass-embedded(recommended).~in module paths.