Merge pull request #514 from andrewballantyne/update-2.4-dashboard

Dashboard 2.4 manifests updates
red-hat-data-services · Oct 25, 2023 · 64e451e · 64e451e
2 parents b1bc0bb + 05a370d
commit 64e451e
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/odh-dashboard/apps/base/jupyter/jupyter-app.yaml b/odh-dashboard/apps/base/jupyter/jupyter-app.yaml
@@ -170,7 +170,7 @@ spec:
   kfdefApplications:
     - odh-notebook-controller
     - notebook-images
-  support: redhat
+  support: red hat
   provider: Jupyter
   docsLink: 'https://jupyter.org'
   quickStart: create-jupyter-notebook

diff --git a/odh-dashboard/apps/base/jupyter/jupyterhub-app.yaml b/odh-dashboard/apps/base/jupyter/jupyterhub-app.yaml
@@ -84,7 +84,7 @@ spec:
       </g>
     </svg>
   category: Red Hat managed
-  support: redhat
+  support: red hat
   docsLink: https://jupyter.org/hub
   quickStart: create-jupyter-notebook
   getStartedLink: https://jupyterhub.readthedocs.io/en/stable/getting-started/index.html

diff --git a/odh-dashboard/base/cluster-role.yaml b/odh-dashboard/base/cluster-role.yaml
@@ -164,3 +164,11 @@ rules:
       - delete
     resources:
       - notebooks
+  - apiGroups:
+      - datasciencecluster.opendatahub.io
+    verbs:
+      - list
+      - watch
+      - get
+    resources:
+      - datascienceclusters
diff --git a/odh-dashboard/crd/acceleratorprofiles.opendatahub.io.crd.yaml b/odh-dashboard/crd/acceleratorprofiles.opendatahub.io.crd.yaml
@@ -28,27 +28,36 @@ spec:
               properties:
                 displayName:
                   type: string
+                  description: "The display name of the accelerator profile."
                 enabled:
                   type: boolean
+                  description: "Indicates whether the accelerator profile is available for new resources."
                 identifier:
                   type: string
+                  description: "The resource identifier of the accelerator device. Example: nvidia.com/gpu"
                 description:
                   type: string
+                  description: "A short description of the accelerator profile."
                 tolerations:
                   type: array
+                  description: "Any number of Kubernetes toleration values that are added to resources when created or updated to this accelerator profile."
                   items:
                     type: object
                     required:
                       - key
                     properties:
                       key:
                         type: string
+                        description: "Taint key. Empty matches all keys."
                       operator:
                         type: string
+                        description: "Relationship with the value. Valid: 'Exists', 'Equal'. Defaults to 'Equal'."
                       value:
                         type: string
+                        description: "Tolerance value. If key is empty, use 'Exists' to match all values and keys."
                       effect:
                         type: string
+                        description: "Taint effect. Empty matches all effects. Allowed: 'NoSchedule', 'PreferNoSchedule', 'NoExecute'."
                       tolerationSeconds:
                         type: integer
-
+                        description: "Duration in seconds. If effect is 'NoExecute', specifies eviction time. Default is forever."