Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAI: Build VSCode notebook on RHEL9 base #93

Closed
wants to merge 1 commit into from

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Nov 6, 2023

This PR incorporates the VSCode notebook to RHOAI.

How has been tested:
The behavior of the notebook looks the same as the one based on C9S in ODH.
The RHEL base image that used is : https://catalog.redhat.com/software/containers/rhel9/python-39/61a6101fbfd4a5234d59629d?architecture=amd64&image=65301f5a53a51a886582fba1

1. On a Local Run

  1. Build the notebook: make codeserver-rhel9-python-3.9
  2. Run the VSCode locally:
    podman run --network=host --name validation-container quay.io/rh_ee_atheodor/workbench-images:codeserver-rhel9-python-3.9-2023b_20231106

image

Once you finish the inspection: podman stop validation-container && podman rm validation-container

2. On the Cluster

Deploy on the cluster: make deploy-rhel9-codeserver-rhel9-python-3.9
Run the Test: make validate-codeserver-image image=codeserver-rhel9-python-3.9-2023b_20231106 ensure that the test completed successfully
Undeploy: make undeploy-rhel9-codeserver-rhel9-python-3.9

Copy link

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member Author

atheo89 commented Nov 6, 2023

This closed because changed the name of the branch after push the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant