Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the notebook manifests with 2024b image reference #389

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

dibryant
Copy link

@dibryant dibryant commented Oct 3, 2024

Fixes for https://issues.redhat.com/browse/RHOAIENG-12629

Updated the notebook manifests with 2024b and 2024a image references

@dibryant dibryant force-pushed the manifest-ds branch 2 times, most recently from a330c89 to db8ea3a Compare October 3, 2024 18:03
Copy link

openshift-ci bot commented Oct 3, 2024

@dibryant: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images db8ea3a link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@atheo89
Copy link
Member

atheo89 commented Oct 4, 2024

Hi Diamond, I have two comments:

  • Please review and incorporate the changes from the upstream PR: Updated the notebook manifests with 2024b image reference opendatahub-io/notebooks#721.

  • We'll need to adjust all the tag versions by shifting them down and introducing the new version, 24b, as N. This change will need to be reflected across all the related files (ImageStreams, check-params-env.sh, params., commits., kustomization.yml). Please take extra care during this process, as it's easy to accidentally cause misalignments.

    • N - 2024.2
    • N-1 - 2024.1
    • N-2 - 2023.2
    • N-3 - 2023.1
    • N-4 - 1.2

@harshad16
Copy link
Member

/lgtm
/approve

There are some bits, which needs to be adjust, they would followed up in next set of PR's.
Example:

  • verifying the annotation

Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@harshad16
Copy link
Member

Merging to move along the process.

@harshad16 harshad16 merged commit ead3682 into red-hat-data-services:main Oct 4, 2024
5 of 9 checks passed
@@ -91,143 +91,178 @@ function check_image_variable_matches_name_and_commitref() {
local expected_build_name # Why some of the images has `-amd64` suffix and others not?
case "${image_variable}" in
odh-minimal-notebook-image-n)
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
expected_commitref="release-2024b"
expected_build_name="jupyter-minimal-ubi9-python-3.9-amd64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these aren't correct, similar to other occurrences - though, the CI failed so it's clear and should be fixed in the followup then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants