Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAI] Updated image manifests with AMD images for minimal pytorch and tensorflow #361

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dibryant
Copy link

Fixes for https://issues.redhat.com/browse/RHOAIENG-6447
Updated imagestream for AMD minimal pytorch and tensorflow for users that want OOTB workbench images with AMD libraries & package

Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Diamond, we need to modify as well the kustomization.yaml file to incorporate the new images. Moreover, I left some more comments on the review.

manifests/base/rstudio-buildconfig.yaml Outdated Show resolved Hide resolved
rstudio/rhel9-python-3.9/Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put some comments. Also, I think that this is missing the changes for kustomization.yaml?

Copy link

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

manifests/base/params.env Outdated Show resolved Hide resolved
manifests/base/commit.env Outdated Show resolved Hide resolved
;;
odh-rocm-tensorflow-notebook-image-n)
expected_name="odh-notebook-jupyter-rocm-tensorflow-ubi9-python-3.9"
expected_commitref="2024a"
Copy link
Member

@jstourac jstourac Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we plan to include these images in 2024b and we don't have any image build for 2024a anyway, keep the following there for now so this CI pass and we'll update later:

#expected_commitref="release-2024b"
expected_commitref="main"

@jstourac
Copy link
Member

@atheo89 a curious question - since these will be part of 2024b, are we sure we want the rocm records mentioned in the following files?

Will the relevant 2024b configuration be copied from main or 2024a files there?

Copy link

openshift-ci bot commented Sep 11, 2024

@dibryant: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images aa22626 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@atheo89
Copy link
Member

atheo89 commented Sep 13, 2024

@atheo89 a curious question - since these will be part of 2024b, are we sure we want the rocm records mentioned in the following files?

Hey @jstourac, correct. We should remove them from 2024a, probably we had to keep them only in main till the 2024b branch be ready

@atheo89
Copy link
Member

atheo89 commented Sep 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants