-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAI] Updated image manifests with AMD images for minimal pytorch and tensorflow #361
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Diamond, we need to modify as well the kustomization.yaml
file to incorporate the new images. Moreover, I left some more comments on the review.
manifests/base/jupyter-rocm-tensorflow-notebook-imagestream.yaml
Outdated
Show resolved
Hide resolved
manifests/base/jupyter-rocm-tensorflow-notebook-imagestream.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put some comments. Also, I think that this is missing the changes for kustomization.yaml?
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a4b2fdb
to
2a0f1c7
Compare
55fb160
to
accfd0a
Compare
d45a362
to
58f9423
Compare
a4b8edd
to
172a877
Compare
ci/check-params-env.sh
Outdated
;; | ||
odh-rocm-tensorflow-notebook-image-n) | ||
expected_name="odh-notebook-jupyter-rocm-tensorflow-ubi9-python-3.9" | ||
expected_commitref="2024a" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we plan to include these images in 2024b
and we don't have any image build for 2024a
anyway, keep the following there for now so this CI pass and we'll update later:
#expected_commitref="release-2024b"
expected_commitref="main"
@atheo89 a curious question - since these will be part of 2024b, are we sure we want the rocm records mentioned in the following files?
Will the relevant 2024b configuration be copied from main or 2024a files there? |
@dibryant: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
Fixes for https://issues.redhat.com/browse/RHOAIENG-6447
Updated imagestream for AMD minimal pytorch and tensorflow for users that want OOTB workbench images with AMD libraries & package