Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branch for the RStudio build config definitions #350

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Aug 7, 2024

No description provided.

@jstourac jstourac self-assigned this Aug 7, 2024
@openshift-ci openshift-ci bot requested review from atheo89 and dibryant August 7, 2024 11:16
@jstourac jstourac requested review from harshad16 and removed request for dibryant August 8, 2024 07:46
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, if we dont have any change between version to version, we should be fine using the older version.
we get only at fault if it references main branch which is fast moving.

/lgtm
/approve

Copy link

openshift-ci bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bb2e243 into red-hat-data-services:rhoai-2.13 Aug 8, 2024
7 checks passed
@jiridanek
Copy link
Member

jiridanek commented Aug 9, 2024

we get only at fault if it references main branch which is fast moving.

and if we're dealing with stable/eus and we need to patch or update something in the Dockerfile, then it's also best to have the branches lined up properly to begin with

@jstourac jstourac deleted the updateRstudioBranch branch August 12, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants