Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI and GHA] add basic checks for params.env and commit.env files content and also runtime images check #330

Draft
wants to merge 4 commits into
base: release-2023b
Choose a base branch
from
Draft

[CI and GHA] add basic checks for params.env and commit.env files content and also runtime images check #330

wants to merge 4 commits into from

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Jul 18, 2024 •
edited
Loading

This is similar to what was done in #263.

  1. This adds basic checks for the content in params.env and commit.env files.
  2. The commit reference for code-server is wrong - this PR fixes this too, which is kind of a functional change.
  3. This also backport some changes to the code-quality GHA to make it run more often and updates the way the yaml files are checked and adds a kustomize dry-run.

https://issues.redhat.com/browse/RHOAIENG-7884

Moving this to draft for now until #331 is merged.

@jstourac jstourac requested review from jiridanek, harshad16 and atheo89 and removed request for rkpattnaik780 July 18, 2024 12:03
@jstourac jstourac marked this pull request as draft July 18, 2024 12:34
@jstourac jstourac mentioned this pull request Aug 28, 2024
Merged
@jstourac
[GHA] Backport relevant code-quality changes from main
f010619 
Updates the code-quality GitHub action with relevant changes from main
branch:
* yaml linting updated
* added a dry run for the kustomize files in manifests/base and
  manifests/overlays/additional directories
* the action is now run on push, pull_reuqest and workflow_dispatch
@jstourac
[CI] backported CI checks from main branch
b044bc9 
These checks perform basic static check for the referenced images
in params.env and relevant commit.env files. It also performs
basic static check for the referenced runtime images.
@jstourac
Fix/Unify naming of the variables used for the code-server image
b7da19f 
This should also fix the commit ID update in the commit.env file for
this image.
@jstourac
Fix the commit ID reference for the code-server image
db29fbd
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jstourac. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac
Copy link
Member Author

jstourac commented Aug 29, 2024 •
edited
Loading

We should do as many as possible via the upstream/2023b branch sync. Thus even though the #331 has been merged, I'm keeping this in draft to recall myself that we need to do the change in upstream first... once done, I think that this may be closed or used for the narrowing of the eventual CI failures due to the changes between the upstream and downstream branches 🤔

update: question is also, what all checks we actually want to add for this branch, technically the params.env checks aren't very useful here... but having the CI united in all our branches makes the less differences which should make less headaches during the branch syncing (hopefully?)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibryant dibryant Awaiting requested review from dibryant

@jiridanek jiridanek Awaiting requested review from jiridanek

@harshad16 harshad16 Awaiting requested review from harshad16

@atheo89 atheo89 Awaiting requested review from atheo89

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jstourac