-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci to function with params of ODH-NBC RHOAI #62
Fix ci to function with params of ODH-NBC RHOAI #62
Conversation
ddfc6d8
to
d276d76
Compare
@harshad16 the CI was already running before on your own fork, so here's result from that https://github.com/harshad16/odh-kubeflow/actions/runs/9521843160/job/26250153715 |
d276d76
to
bea33ff
Compare
Signed-off-by: Harshad Reddy Nalla <[email protected]>
bea33ff
to
f1b1ae0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last CI run in https://github.com/harshad16/odh-kubeflow/actions/runs/9522071266/job/26250836049 now failed on issue https://issues.redhat.com/browse/RHOAIENG-72 which is as expected. Thanks for the fix.
I'm adding the difference between opendatahub-io and red-hat-data-services manifests to the office hours agenda; hopefully we can agree on unifying the code across repos as much as possible.
Thanks for the fix! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89, jiridanek, jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cb8f616
into
red-hat-data-services:master
Fix ci to function with params of ODH-NBC RHOAI
Related-to: #61 (comment)