Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the unit test for notebook-controller #30

Closed

Conversation

harshad16
Copy link
Member

sync the downstream master with v1.7-branch to get fix for the unit test.

@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

feat: disables features not needed for Istio deployments
@harshad16
Copy link
Member Author

/hold

Wait for some time.

fix: Upgrade the golang version and indirect dep net, grpc
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the red-hat-data-services org. You can then trigger verification by writing /verify-owners in a comment.

  • aslakknutsen
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • components/notebook-controller/config/overlays/service-mesh/OWNERS
  • bartoszmajsak
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • components/notebook-controller/config/overlays/service-mesh/OWNERS
  • cam-garrison
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • components/notebook-controller/config/overlays/service-mesh/OWNERS

@harshad16 harshad16 closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants