Skip to content
Code static analysis

Merge pull request #68 from opendatahub-io/stable #17

Sign in to view logs

Merge pull request #68 from opendatahub-io/stable

Merge pull request #68 from opendatahub-io/stable #17

Triggered via push July 9, 2024 14:20
@VaniHaripriyaVaniHaripriya
pushed 750bf13
snyk-fix-c6dc5812735174c3f458019c04071bf7
Status Failure
Total duration 1m 33s
Artifacts –

code-quality.yaml

on: push
Matrix: golangci-lint
Matrix: govulncheck
Fit to window
Zoom out
Zoom in

Annotations

40 errors
govulncheck (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper.go#L24
undefined: testContext
govulncheck (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper.go#L52
undefined: testContext
govulncheck (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper.go#L74
undefined: testContext
govulncheck (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper.go#L90
undefined: testContext
govulncheck (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper.go#L112
undefined: testContext
govulncheck (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper.go#L130
undefined: testContext
govulncheck (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper.go#L144
undefined: testContext
govulncheck (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper.go#L159
undefined: notebookContext
govulncheck (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper.go#L235
undefined: notebookContext
govulncheck (components/odh-notebook-controller): components/odh-notebook-controller/e2e/helper.go#L235
undefined: DeploymentMode
govulncheck (components/notebook-controller)
notebook.main calls manager.New, which eventually calls http2.ConfigureTransports
govulncheck (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.ConnectionError.Error
govulncheck (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.ErrCode.String
govulncheck (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.FrameHeader.String
govulncheck (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.FrameType.String
govulncheck (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.GoAwayError.Error
govulncheck (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.Setting.String
govulncheck (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.SettingID.String
govulncheck (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.StreamError.Error
govulncheck (components/notebook-controller)
culler.getNotebookResourceResponse calls http.Client.Get, which eventually calls http2.Transport.NewClientConn
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller_test.go#L256
Error return value is not checked (errcheck)
golangci-lint (components/notebook-controller): components/notebook-controller/api/v1beta1/notebook_webhook.go#L24
var `notebooklog` is unused (unused)
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/suite_test.go#L43
var `cfg` is unused (unused)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L346
S1039: unnecessary use of fmt.Sprintf (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L373
S1039: unnecessary use of fmt.Sprintf (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller.go#L380
S1039: unnecessary use of fmt.Sprintf (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L325
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.KernelStatus is defined as zero (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/pkg/culler/culler.go#L362
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.TerminalStatus is defined as zero (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller.go#L359
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.KernelStatus is defined as zero (gosimple)
golangci-lint (components/notebook-controller): components/notebook-controller/controllers/culling_controller.go#L395
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/controllers.TerminalStatus is defined as zero (gosimple)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_controller.go#L104
Error return value of `retry.OnError` is not checked (errcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_oauth.go#L190
Error return value of `rand.Read` is not checked (errcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/suite_test.go#L56
var `cfg` is unused (unused)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_route.go#L47
SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_webhook.go#L187
SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_webhook.go#L210
SA1019: pointer.Int32Ptr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_controller_test.go#L155
SA1019: pointer.BoolPtr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_controller_test.go#L156
SA1019: pointer.BoolPtr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_controller_test.go#L447
SA1019: pointer.BoolPtr is deprecated: Use ptr.To instead. (staticcheck)
golangci-lint (components/odh-notebook-controller): components/odh-notebook-controller/controllers/notebook_network.go#L20
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)