Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Updated Schema to Latest Release #86

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

JamsRepos
Copy link
Contributor

@rcdailey rcdailey requested a review from yammes08 August 5, 2024 13:25
Copy link
Contributor

@yammes08 yammes08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @JamsRepos! This looks mostly good to me but there are a couple of considerations:

  • Merging this will break Recyclarr for users running <7.2.0 - this will need communicating, and necessitate a short delay
  • Every template needs to have the dates in the header updated - if you can update these to 2024-08-08, then we will look to merge on that date.

@JamsRepos
Copy link
Contributor Author

Yeah apologies - I completely forgot about how it would reflect for the previous versions, it dawned on me as I posted the PR as I was getting warnings on my Recyclarr so I thought i'd do it but then realised not all people would be on the latest 🙊.

I'll get the timestamps done later today as well as do any final sweeps to make sure there's none i've missed (comments included).

@JamsRepos JamsRepos changed the title Updated Schema to Latest Release refactor: Updated Schema to Latest Release Aug 5, 2024
@yammes08 yammes08 added the do not merge Waiting for something before this can be merged label Aug 5, 2024
@yammes08
Copy link
Contributor

yammes08 commented Aug 5, 2024

Yeah apologies - I completely forgot about how it would reflect for the previous versions, it dawned on me as I posted the PR as I was getting warnings on my Recyclarr so I thought i'd do it but then realised not all people would be on the latest 🙊.

I'll get the timestamps done later today as well as do any final sweeps to make sure there's none i've missed (comments included).

Thanks! Looks good to me now so I'll merge this on 08/08.

@yammes08 yammes08 removed the do not merge Waiting for something before this can be merged label Aug 8, 2024
@yammes08 yammes08 dismissed their stale review August 8, 2024 12:04

Changes made

@yammes08 yammes08 merged commit c66c0d7 into recyclarr:master Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants