Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(french-radarr): update recyclarr configs #35

Merged

Conversation

NiceTSY
Copy link
Contributor

@NiceTSY NiceTSY commented Sep 4, 2023

Purpose

Update all 8 French Radarr Recyclarr template configuration files to latest development.

To-do list

  • French HD Bluray + WEB (MULTi)
  • French HD Bluray + WEB (VOSTFR)
  • French HD Remux + WEB (MULTi)
  • French HD Remux + WEB (VOSTFR)
  • French Remux + WEB 2160p (MULTi)
  • French Remux + WEB 2160p (VOSTFR)
  • French UHD Bluray + WEB (MULTi)
  • French UHD Bluray + WEB (VOSTFR)

@rcdailey
Copy link
Member

rcdailey commented Sep 4, 2023

Please rebase your branch to pull in the latest changes on master. I have fixed the issue of the workflows not running in your PR.

@rcdailey rcdailey force-pushed the fix/french-radarr-update-recyclarr-configs branch from a1a0634 to 24703e2 Compare September 4, 2023 16:51
@rcdailey
Copy link
Member

rcdailey commented Sep 4, 2023

Never mind, I was able to rebase from the PR 👍🏻

I will let yammes approve and merge.

@NiceTSY
Copy link
Contributor Author

NiceTSY commented Sep 6, 2023

Just saw that the latest merge from 'master' added some yamlint errors, will correct them tomorrow :)

@rcdailey
Copy link
Member

rcdailey commented Sep 6, 2023

Just saw that the latest merge from 'master' added some yamlint errors, will correct them tomorrow :)

Yes, I recently "polished up" the yaml lint rules. I apologize for the inconvenience!

@NiceTSY
Copy link
Contributor Author

NiceTSY commented Sep 7, 2023

Haha, no worries, I should have seen them as well before the PR

@rcdailey rcdailey force-pushed the fix/french-radarr-update-recyclarr-configs branch from 9553f6d to ee2d85f Compare September 7, 2023 20:05
@yammes08 yammes08 force-pushed the fix/french-radarr-update-recyclarr-configs branch from ee2d85f to 4c9bd46 Compare September 12, 2023 19:50
@yammes08
Copy link
Contributor

yammes08 commented Sep 12, 2023

@NiceTSY - I've noticed you've changed the name of the instances in the config files. These will still work fine as they are, but if any of your users are copy/pasting updated copies of the files they'll get errors about custom format ownership unless they use replace_existing_custom_formats. Just wanted to check with you before merging. Ignore this, I'm wrong.

@rcdailey
Copy link
Member

@yammes08 I just want to clarify that as of modern versions of Recyclarr, the instance name is no longer a part of the hash that gets generated for the cache directory. So the name changes at face value shouldn't cause issues there; although we still need to be careful of conflicting names (i.e. two or more files with the same instance names).

@yammes08
Copy link
Contributor

Aaah yes - forgot that! These are good to go then.

@yammes08 yammes08 merged commit 9822582 into recyclarr:master Sep 12, 2023
2 checks passed
@NiceTSY NiceTSY deleted the fix/french-radarr-update-recyclarr-configs branch September 20, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants