Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vec2: add new function glm_vec2_make #324

Merged
merged 2 commits into from
Jul 2, 2023

Conversation

EasyIP2023
Copy link
Contributor

Just a copy of glm_vec2, but with the
word _make suffixed at the end.

Function takes in a float array array must be
at least of size 2 and converts it into
a 2D vector.

Hey, @recp finishing off last _make calls to close off #284.

Realized for vec2 there's no point in extra function glm_vec2_make as it's already defined as
glm_vec2. Creating PR for discussion. Also do we want to create new headers for the
other matrices?

EasyIP2023 and others added 2 commits July 2, 2023 12:41
Just a copy of glm_vec2, but with the
word _make suffixed at the end.

Function takes in a float array array must be
at least of size 2 and converts it into
a 2D vector.

Signed-off-by: Vincent Davis Jr <[email protected]>
@recp recp merged commit 487b18e into recp:master Jul 2, 2023
32 checks passed
@recp
Copy link
Owner

recp commented Jul 2, 2023

@EasyIP2023 many thanks for your contributions, the PR is merged 🚀

@recp
Copy link
Owner

recp commented Jul 2, 2023

Realized for vec2 there's no point in extra function glm_vec2_make as it's already defined as glm_vec2

Actually it would be nice to make them homogenous as all use _make.

Maybe we should use glm_vec2, glm_vec3 and glm_vec4 for filling vector by individual items e.g.

glm_vec2(x, y, dest);
glm_vec3(x, y, z, dest);
glm_vec4(x, y, z, w, dest);

we can discuss this in separate issue to get more feedback maybe.

Also do we want to create new headers for the
other matrices?

mat2x3
mat2x4
mat3x2
mat3x4
mat4x2
mat4x3

that would be awesome, yes :)

@EasyIP2023 EasyIP2023 deleted the feature/glm_vec2_make branch July 2, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants