Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2163 #2164

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix #2163 #2164

merged 2 commits into from
Sep 9, 2024

Conversation

daviddavo
Copy link
Collaborator

Signed-off-by: David Davó [email protected]

Description

If a user has voted in every item, the sample_neg function in ImplicitCF will enter an infinite loop.

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

miguelgfierro
miguelgfierro requested changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change ask

recommenders/models/deeprec/DataModel/ImplicitCF.py Outdated Show resolved Hide resolved
@daviddavo
Changed assert to ValueError
84497f2 
Signed-off-by: David Davó <[email protected]>
@miguelgfierro miguelgfierro merged commit edca084 into staging Sep 9, 2024
38 checks passed
@miguelgfierro miguelgfierro deleted the hotfix-2163 branch September 9, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@SimonYansenZhao SimonYansenZhao Awaiting requested review from SimonYansenZhao SimonYansenZhao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviddavo @miguelgfierro