Fix DCDIAG and added Diagrammer.Core Module dependency

rebelinux · Feb 20, 2024 · 54168df · 54168df
1 parent 5b2e8e7
commit 54168df
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/Release.yml b/.github/workflows/Release.yml
@@ -25,6 +25,10 @@ jobs:
         shell: pwsh
         run: |
           Install-Module -Name PScriboCharts -Repository PSGallery -Force
+      - name: Install Diagrammer.Core module
+        shell: pwsh
+        run: |
+          Install-Module -Name Diagrammer.Core -Repository PSGallery -Force
       - name: Install Diagrammer.Microsoft.AD module
         shell: pwsh
         run: |

diff --git a/Src/Private/Get-AbrADDCDiag.ps1 b/Src/Private/Get-AbrADDCDiag.ps1
@@ -30,7 +30,7 @@ function Get-AbrADDCDiag {
     }
 
     process {
-        if ($DC) {
+        if (Test-Connection -ComputerName $DC -Quiet -Count 2) {
             try {
                 $DCDIAG = Invoke-DcDiag -DomainController $DC
                 if ($DCDIAG) {
@@ -92,9 +92,10 @@ function Get-AbrADDCDiag {
             } catch {
                 Write-PScriboMessage -IsWarning "Active Directory DCDiag Section: $($_.Exception.Message)"
             }
+        } else {
+            Write-PScriboMessage -IsWarning "Active Directory DCDiag Section: Unable to connect to DC server $DC."
         }
     }
 
     end {}
-
 }