This repository has been archived by the owner on Nov 20, 2020. It is now read-only.
Feat/optimistic response #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbirkegaard
commented
Dec 15, 2019
Comment on lines
+15
to
+25
| type t = { | ||
| . | ||
| "__typename": string, | ||
| "updatePerson": { | ||
| . | ||
| "__typename": string, | ||
| "age": int, | ||
| "id": string, | ||
| "name": string, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
As it it's is now, this should be compatible with all versions of bucklescript, but can be changed to only work with bucklescript >= 7 if that's preferred.
fakenickels
reviewed
Dec 16, 2019
| @@ -11,6 +11,34 @@ module EditPersonMutation = [%graphql | |||
| |} | |||
| ]; | |||
|
|
|||
| module OptimisticResponse = { | |||
| type t = { | |||
There was a problem hiding this comment.
can you add a comment that this is necessary because the types graphql_ppx_re generates are not 1:1 to the JS representation and probably this won't be necessary as soon as teamwalnut/graphql-ppx#20 gets merged?
There was a problem hiding this comment.
I didn't have time to check back in before now. Would you still like me to add it?
There was a problem hiding this comment.
would be appreciated! I haven't published yet
|
looks good to me! after that comment we're good to merge |
|
Released under v4.1.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds optimistic response to
ApolloHooksMutationand updates the Persons example to show how to correctly construct an optimistic response that apollo can understand.