Adding macOS support for static Objective-C framework #6021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest Realm Cocoa changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tgoyne! Long time no see! I hope everyone's been doing well!
I'm working on a small CLI tool to dynamically produce Realm files on macOS. Since CLI programs can't link to dynamic frameworks very easily, I thought it would be easier to just statically link a copy of Realm Objective-C.
But it turns out Realm Objective-C only supports dynamic frameworks on macOS for now.
I asked @bdash a while back and he said the only thing that should be needed to get static support working is to add
macosxto the list of supported platforms.I made that change, and it all seems to be working now. Since this adds a small bit of value back to Realm Cocoa, I thought I'd submit a PR.
I realize that in terms of build process and testability, it might require some more work to get this fully integrated. I'm happy to help anyway I can. Let me know. :)
Thanks!