-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crates: Upgrade dependencies #1238
Open
ethan-readyset
wants to merge
8
commits into
Ib15333b66c6bba2e3eb4a302ea85c3a03ab0acf5
Choose a base branch
from
I9f50620001055aca48616d602ab12a4791b57d17
base: Ib15333b66c6bba2e3eb4a302ea85c3a03ab0acf5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
crates: Upgrade dependencies #1238
ethan-readyset
wants to merge
8
commits into
Ib15333b66c6bba2e3eb4a302ea85c3a03ab0acf5
from
I9f50620001055aca48616d602ab12a4791b57d17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readysetbot
force-pushed
the
Ib15333b66c6bba2e3eb4a302ea85c3a03ab0acf5
branch
10 times, most recently
from
April 25, 2024 20:44
bfaf105
to
40dd4be
Compare
commit message Change-Id: Ibbc34e0856ed22b475e75262e14f8d55995089d8
This reverts commit bde05974330a69526f06f1fbcafab925064cd659. Change-Id: I56b71ed96e508ac617579ca1d0e181a1387671f1
This reverts commit 337df377be353ebd4f0fa548f1301997ba7d3e28. Change-Id: I73174d2aa27cb077941eab13ab1b613a6e6a4a07
Native async traits were stabilized as of Rust 1.75, so we no longer need the async_trait crate in many situations. This commit replaces the 3rd party crate with the native version everywhere we can. The areas of the code that still require the 3rd party crate include: - Any trait that is used as a trait object (this is not supported natively by Rust yet) - Certain traits that returned lifetime errors when attempting to remove the `#[async_trait]` macro (these errors included a message that said the error was a known limitation and would be removed in the future) - The trait in proptest-stateful, whose interface I didn't want to change without further discussion, since it's a publicly-available trait Change-Id: I5c761c075966e4fcebbb6d4955608107cf871b7c
`OnceCell` was added to the Rust standard library a while back, so it is no longer necessary to use the 3rd party crate. This commit removes the crate, replacing our only usage of `OnceCell` with `OnceLock`, which is a thread-safe alternative. Change-Id: Ifdb622c34c24ff40836276e25d2db8c33a2694df
This commit removes some unused dependencies as reported by `cargo udeps`. Change-Id: Iebcf5c662b392f2825232cc75a587d770105bfb0
readysetbot
force-pushed
the
Ib15333b66c6bba2e3eb4a302ea85c3a03ab0acf5
branch
from
April 26, 2024 15:15
40dd4be
to
18044db
Compare
This commit upgrades many of our dependencies to newer versions. Note that this was not just the result of a `cargo update` invocation; I used the `cargo-edit` tool to automate the process of upgrading crate versions in our Cargo.toml (I also ran `cargo update` afterwards for good measure). The code changes in this commit reflect breaking API changes in the new package versions. Change-Id: Ib15333b66c6bba2e3eb4a302ea85c3a03ab0acf5
This commit upgrades many of our dependencies to newer versions. Note that this was not just the result of a `cargo update` invocation; I used the `cargo-edit` tool to automate the process of upgrading crate versions in our Cargo.toml (I also ran `cargo update` afterwards for good measure). The code changes in this commit reflect breaking API changes in the new package versions. Change-Id: I9f50620001055aca48616d602ab12a4791b57d17
readysetbot
force-pushed
the
Ib15333b66c6bba2e3eb4a302ea85c3a03ab0acf5
branch
from
May 4, 2024 00:51
18044db
to
1ec7d26
Compare
readysetbot
force-pushed
the
I9f50620001055aca48616d602ab12a4791b57d17
branch
from
May 4, 2024 00:51
74542f5
to
e532cd8
Compare
readysetbot
force-pushed
the
Ib15333b66c6bba2e3eb4a302ea85c3a03ab0acf5
branch
6 times, most recently
from
May 7, 2024 15:26
d59c9f2
to
7cf68d7
Compare
readysetbot
force-pushed
the
Ib15333b66c6bba2e3eb4a302ea85c3a03ab0acf5
branch
from
May 13, 2024 16:24
7cf68d7
to
f0a4a14
Compare
readysetbot
force-pushed
the
Ib15333b66c6bba2e3eb4a302ea85c3a03ab0acf5
branch
2 times, most recently
from
May 21, 2024 20:08
29eb728
to
dec04f5
Compare
readysetbot
force-pushed
the
Ib15333b66c6bba2e3eb4a302ea85c3a03ab0acf5
branch
4 times, most recently
from
May 23, 2024 15:06
e774ed0
to
d1638d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades many of our dependencies to newer versions. Note
that this was not just the result of a
cargo update
invocation; I usedthe
cargo-edit
tool to automate the process of upgrading crateversions in our Cargo.toml (I also ran
cargo update
afterwards forgood measure). The code changes in this commit reflect breaking API
changes in the new package versions.