-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: Remove unused dependencies #1236
Open
ethan-readyset
wants to merge
3
commits into
Ifdb622c34c24ff40836276e25d2db8c33a2694df
Choose a base branch
from
Iebcf5c662b392f2825232cc75a587d770105bfb0
base: Ifdb622c34c24ff40836276e25d2db8c33a2694df
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
treewide: Remove unused dependencies #1236
ethan-readyset
wants to merge
3
commits into
Ifdb622c34c24ff40836276e25d2db8c33a2694df
from
Iebcf5c662b392f2825232cc75a587d770105bfb0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
April 23, 2024 22:18
a1680e6
to
a88480a
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
April 23, 2024 22:18
2b4c978
to
aac1708
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
April 23, 2024 22:42
a88480a
to
a752693
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
April 23, 2024 22:42
aac1708
to
6f0f039
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
April 23, 2024 23:01
a752693
to
469ddfc
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
April 23, 2024 23:01
6f0f039
to
2fec3d5
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
April 23, 2024 23:11
469ddfc
to
47b307b
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
April 23, 2024 23:11
2fec3d5
to
ee7c382
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
April 23, 2024 23:15
47b307b
to
a21dc1d
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
April 23, 2024 23:15
ee7c382
to
4d44df8
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
April 24, 2024 17:31
a21dc1d
to
929728d
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
April 24, 2024 17:31
4d44df8
to
d9192d6
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
April 24, 2024 19:16
929728d
to
9dfd8c1
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
April 24, 2024 19:16
d9192d6
to
aa67b34
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
April 24, 2024 19:58
9dfd8c1
to
b2df6a0
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
April 24, 2024 19:58
aa67b34
to
047246b
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
April 25, 2024 20:44
b2df6a0
to
7f7801f
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
April 25, 2024 20:44
047246b
to
7d30ea6
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
April 26, 2024 15:15
7f7801f
to
2454beb
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
April 26, 2024 15:15
7d30ea6
to
37470e5
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
May 6, 2024 19:07
2454beb
to
a99f8b1
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
May 6, 2024 19:07
37470e5
to
d54d84d
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
May 6, 2024 19:19
a99f8b1
to
48d04dc
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
May 6, 2024 19:19
d54d84d
to
4c03d58
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
May 6, 2024 19:43
48d04dc
to
680c9f7
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
May 6, 2024 19:43
4c03d58
to
b3c938d
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
May 6, 2024 20:27
680c9f7
to
09519b7
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
May 6, 2024 20:27
b3c938d
to
b87fd42
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
May 7, 2024 15:26
09519b7
to
ace4955
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
May 7, 2024 15:26
b87fd42
to
5382aa8
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
May 13, 2024 16:23
ace4955
to
2e7a26b
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
May 13, 2024 16:24
5382aa8
to
0aad3a8
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
May 21, 2024 20:05
2e7a26b
to
13b71a6
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
May 21, 2024 20:05
0aad3a8
to
5a4116e
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
May 21, 2024 20:08
13b71a6
to
9db3853
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
May 21, 2024 20:08
5a4116e
to
0d9fb1b
Compare
readysetbot
force-pushed
the
Ifdb622c34c24ff40836276e25d2db8c33a2694df
branch
from
May 22, 2024 16:02
9db3853
to
d1a351f
Compare
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
May 22, 2024 16:02
0d9fb1b
to
203e12c
Compare
Native async traits were stabilized as of Rust 1.75, so we no longer need the async_trait crate in many situations. This commit replaces the 3rd party crate with the native version everywhere we can. The areas of the code that still require the 3rd party crate include: - Any trait that is used as a trait object (this is not supported natively by Rust yet) - Certain traits that returned lifetime errors when attempting to remove the `#[async_trait]` macro (these errors included a message that said the error was a known limitation and would be removed in the future) - The trait in proptest-stateful, whose interface I didn't want to change without further discussion, since it's a publicly-available trait Change-Id: I5c761c075966e4fcebbb6d4955608107cf871b7c Reviewed-on: https://gerrit.readyset.name/c/readyset/+/7375 Tested-by: Buildkite CI Reviewed-by: Jason Brown <[email protected]>
`OnceCell` was added to the Rust standard library a while back, so it is no longer necessary to use the 3rd party crate. This commit removes the crate, replacing our only usage of `OnceCell` with `OnceLock`, which is a thread-safe alternative. Change-Id: Ifdb622c34c24ff40836276e25d2db8c33a2694df Reviewed-on: https://gerrit.readyset.name/c/readyset/+/7376 Tested-by: Buildkite CI Reviewed-by: Jason Brown <[email protected]>
This commit removes some unused dependencies as reported by `cargo udeps`. Change-Id: Iebcf5c662b392f2825232cc75a587d770105bfb0 Reviewed-on: https://gerrit.readyset.name/c/readyset/+/7377 Tested-by: Buildkite CI Reviewed-by: Jason Brown <[email protected]>
readysetbot
force-pushed
the
Iebcf5c662b392f2825232cc75a587d770105bfb0
branch
from
May 22, 2024 19:24
203e12c
to
4786dc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes some unused dependencies as reported by
cargo udeps
.