Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: Remove unused dependencies #1236

Open
wants to merge 3 commits into
base: Ifdb622c34c24ff40836276e25d2db8c33a2694df
Choose a base branch
from

Conversation

ethan-readyset
Copy link

@ethan-readyset ethan-readyset commented Apr 23, 2024

This commit removes some unused dependencies as reported by cargo udeps.

@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from a1680e6 to a88480a Compare April 23, 2024 22:18
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 2b4c978 to aac1708 Compare April 23, 2024 22:18
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from a88480a to a752693 Compare April 23, 2024 22:42
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from aac1708 to 6f0f039 Compare April 23, 2024 22:42
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from a752693 to 469ddfc Compare April 23, 2024 23:01
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 6f0f039 to 2fec3d5 Compare April 23, 2024 23:01
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 469ddfc to 47b307b Compare April 23, 2024 23:11
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 2fec3d5 to ee7c382 Compare April 23, 2024 23:11
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 47b307b to a21dc1d Compare April 23, 2024 23:15
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from ee7c382 to 4d44df8 Compare April 23, 2024 23:15
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from a21dc1d to 929728d Compare April 24, 2024 17:31
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 4d44df8 to d9192d6 Compare April 24, 2024 17:31
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 929728d to 9dfd8c1 Compare April 24, 2024 19:16
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from d9192d6 to aa67b34 Compare April 24, 2024 19:16
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 9dfd8c1 to b2df6a0 Compare April 24, 2024 19:58
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from aa67b34 to 047246b Compare April 24, 2024 19:58
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from b2df6a0 to 7f7801f Compare April 25, 2024 20:44
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 047246b to 7d30ea6 Compare April 25, 2024 20:44
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 7f7801f to 2454beb Compare April 26, 2024 15:15
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 7d30ea6 to 37470e5 Compare April 26, 2024 15:15
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 2454beb to a99f8b1 Compare May 6, 2024 19:07
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 37470e5 to d54d84d Compare May 6, 2024 19:07
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from a99f8b1 to 48d04dc Compare May 6, 2024 19:19
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from d54d84d to 4c03d58 Compare May 6, 2024 19:19
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 48d04dc to 680c9f7 Compare May 6, 2024 19:43
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 4c03d58 to b3c938d Compare May 6, 2024 19:43
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 680c9f7 to 09519b7 Compare May 6, 2024 20:27
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from b3c938d to b87fd42 Compare May 6, 2024 20:27
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 09519b7 to ace4955 Compare May 7, 2024 15:26
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from b87fd42 to 5382aa8 Compare May 7, 2024 15:26
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from ace4955 to 2e7a26b Compare May 13, 2024 16:23
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 5382aa8 to 0aad3a8 Compare May 13, 2024 16:24
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 2e7a26b to 13b71a6 Compare May 21, 2024 20:05
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 0aad3a8 to 5a4116e Compare May 21, 2024 20:05
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 13b71a6 to 9db3853 Compare May 21, 2024 20:08
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 5a4116e to 0d9fb1b Compare May 21, 2024 20:08
@readysetbot readysetbot force-pushed the Ifdb622c34c24ff40836276e25d2db8c33a2694df branch from 9db3853 to d1a351f Compare May 22, 2024 16:02
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 0d9fb1b to 203e12c Compare May 22, 2024 16:02
Native async traits were stabilized as of Rust 1.75, so we no longer need
the async_trait crate in many situations. This commit replaces the 3rd
party crate with the native version everywhere we can. The areas of the
code that still require the 3rd party crate include:

- Any trait that is used as a trait object (this is not supported
  natively by Rust yet)
- Certain traits that returned lifetime errors when attempting to remove
  the `#[async_trait]` macro (these errors included a message that said
  the error was a known limitation and would be removed in the future)
- The trait in proptest-stateful, whose interface I didn't want to change
  without further discussion, since it's a publicly-available trait

Change-Id: I5c761c075966e4fcebbb6d4955608107cf871b7c
Reviewed-on: https://gerrit.readyset.name/c/readyset/+/7375
Tested-by: Buildkite CI
Reviewed-by: Jason Brown <[email protected]>
`OnceCell` was added to the Rust standard library a while back, so it is
no longer necessary to use the 3rd party crate. This commit removes the
crate, replacing our only usage of `OnceCell` with `OnceLock`, which is
a thread-safe alternative.

Change-Id: Ifdb622c34c24ff40836276e25d2db8c33a2694df
Reviewed-on: https://gerrit.readyset.name/c/readyset/+/7376
Tested-by: Buildkite CI
Reviewed-by: Jason Brown <[email protected]>
This commit removes some unused dependencies as reported by `cargo udeps`.

Change-Id: Iebcf5c662b392f2825232cc75a587d770105bfb0
Reviewed-on: https://gerrit.readyset.name/c/readyset/+/7377
Tested-by: Buildkite CI
Reviewed-by: Jason Brown <[email protected]>
@readysetbot readysetbot force-pushed the Iebcf5c662b392f2825232cc75a587d770105bfb0 branch from 203e12c to 4786dc6 Compare May 22, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants