Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docusaurus basics #11752

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docusaurus basics #11752

wants to merge 1 commit into from

Conversation

plaindocs
Copy link
Contributor

@plaindocs plaindocs commented Nov 7, 2024

Not a lot of info here, but probably worth pushing out anyway


📚 Documentation previews 📚

@plaindocs plaindocs requested a review from a team as a code owner November 7, 2024 15:41
@plaindocs plaindocs requested review from humitos and removed request for a team and ericholscher November 7, 2024 15:43
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand, docosaurus renders the docs with JS, that has the downside of some of our integrations that work over the generated HTML not working, like search and content embedding. Maybe have a limitations section?

@plaindocs
Copy link
Contributor Author

@stsewd yup, sounds good, thanks

@humitos
Copy link
Member

humitos commented Nov 11, 2024

like search and content embedding

File Tree Diff won't work here either...

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As Santos mentioned, we should add a "Limitations" section before merging.

Comment on lines +22 to +33
commands:
# "docs/" was created following the Docusaurus tutorial:
# npx create-docusaurus@latest docs classic
# but you can just use your existing Docusaurus site
#
# Install Docusaurus dependencies
- cd docs/ && npm install
# Build the site
- cd docs/ && npm run build
# Copy generated files into Read the Docs directory
- mkdir --parents $READTHEDOCS_OUTPUT/html/
- cp --recursive docs/build/* $READTHEDOCS_OUTPUT/html/
Copy link
Member

@humitos humitos Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we merge and deploy #11710 this would be as following:

build:
  install:
    - cd docs/ && npm install
  build:
    html:
      - cd docs/ && npm run build
  post_build:
    - mkdir --parents $READTHEDOCS_OUTPUT/html/
    - cp --recursive docs/build/* $READTHEDOCS_OUTPUT/html/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants