feat(fetch): use undici + ProxyAgent
#1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turns out this isn't really necessary at all and tests run way faster without this!
kanadgupta
changed the title
node-fetch, formdata-node, mswProxyAgent
kanadgupta
added
enhancement
erunion
approved these changes
May 7, 2024
| @@ -135,7 +133,6 @@ describe('rdme openapi', () => { | |||
| .basicAuth({ user: key }) | |||
| .reply(200, [{ _id: 'spec1', title: 'spec1_title' }]) | |||
| .post('/api/v1/api-specification', { registryUUID }) | |||
| .delayConnection(1000) | |||
|
|
||
| server.use( |
There was a problem hiding this comment.
msw i think you're really neat but my dude... the code bloat
There was a problem hiding this comment.
yeah... once nock started using the same underlying interceptor, it was game over
| "gray-matter": "^4.0.1", | ||
| "ignore": "^5.2.0", | ||
| "mime-types": "^2.1.35", | ||
| "node-fetch": "^3.3.2", |
| ...options, | ||
| headers, | ||
| dispatcher: proxy ? new ProxyAgent(proxy) : undefined, |
There was a problem hiding this comment.
lol @ the way node-fetch forced us to handle proxies 🤡
There was a problem hiding this comment.
lol that was not exactly a node-fetch issue and more of a me issue 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
node-fetchin favor of its native Node.js counterpartformdata-nodein favor of its native Node.js counterpartProxyAgentfor proxying requests1nockbeta in chore(deps):nock@beta,[email protected]#999,mswis no longer required and has been removed.delayConnectionstatements so now tests are like 2-3x faster🧬 QA & Testing
Do tests still pass?
Footnotes
We very well might have been doing proxying incorrectly this entire time? Ideally we should use the new
EnvHttpProxyAgentAPI instead but that's only supported inundici@6😔 ↩