Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ruby): Add _version #956

Merged
merged 3 commits into from
Jan 27, 2024
Merged

fix(ruby): Add _version #956

merged 3 commits into from
Jan 27, 2024

Conversation

hoxworth
Copy link
Contributor

🚥 Resolves ISSUE_ID

🧰 Changes

Add the _version parameter to the payload so the server does not process the headers.

🧬 QA & Testing

Updated a test to ensure the _version parameter is on the payload request.

gratcliff
gratcliff approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@gratcliff gratcliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hoxworth!

@hoxworth
Copy link
Contributor Author

There are some failures, will clean those up.

@hoxworth hoxworth changed the title (feat) Add _version fix(ruby) Add _version Jan 26, 2024
@hoxworth hoxworth changed the title fix(ruby) Add _version fix(ruby): Add _version Jan 26, 2024
@hoxworth hoxworth merged commit c442510 into main Jan 27, 2024
41 checks passed
@hoxworth hoxworth deleted the fix-ruby-hashing branch January 27, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gratcliff gratcliff gratcliff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoxworth @gratcliff