refactor(test): moving all JS unit testing over to Vitest #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my god this is annoying
this was passing before...
weird — when runing npm i from the root on npm@8, this happened 🧐
kanadgupta
reviewed
Aug 23, 2023
erunion
commented
Aug 23, 2023
| "vimeo/psalm": "^5.7", | ||
| "psalm/plugin-laravel": "^2.7" | ||
| "psalm/plugin-laravel": "^2.7", | ||
| "vimeo/psalm": "5.15.0" |
There was a problem hiding this comment.
Forcefully pinned Psalm to a specific version so it stops flaking tests when composer install decides to install a newer version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Vitest slaps (native TS and ESM support, runs test fast, is good) so I'm moving our unit tests over to it.
🧬 QA & Testing