feat: kong plugin #1073
feat: kong plugin #1073
Conversation
There was a problem hiding this comment.
just some documentation nits.
can you also add something to .github/MAINTAINERS.md on how we'll end up deploying this? if that's sensitive info then it can go somewhere in our handbook. would just like to have some docs somewhere on how this gets from this repo to customers.
|
mind also giving this a PR title? 🥺 |
|
|
||
| In the future: | ||
|
|
||
| - We will build a Docker image for the plugin and release it to the Kong Community plugins site. |
There was a problem hiding this comment.
@anandkumarpatel do you have any tickets in place for these tasks? If not, can we start tracking them?
There was a problem hiding this comment.
not yet! where should I add these tickets to? (note, this is just for hackathon, so we wont work on the tickets unless there is traction so not sure if its worth adding them?)
| @@ -0,0 +1,98 @@ | |||
| -- Helper functions provided by Kong Gateway, see https://github.com/Kong/kong/blob/master/spec/helpers.lua | |||
| local helpers = require "spec.helpers" | |||
There was a problem hiding this comment.
While I'm not sure how reasonable it is in this chunk of work, it would be nice to support integration tests for this (and Cloudflare) in our main integration test suite. I think that might require some mocking similar to how Wrangler does it.
There was a problem hiding this comment.
whats our integration test environment like? if it can run docker then we should be able to create some! otherwise we won't really be able to run a kong instance.
| # Run kong with the plugin | ||
| curl -Ls https://get.konghq.com/quickstart | bash -s -- -r "" -i kong-readme-plugin -t v1 | ||
| # Enable the plugin | ||
| curl -isX POST http://localhost:8001/plugins -d name=readme-plugin -d 'config.api_key=<Your API Key>' |
There was a problem hiding this comment.
Why port 8001? What if this is exposed on another port?
There was a problem hiding this comment.
if they ran the above script, its 8001. I am assuming if they don't follow the script they would know what they are doing.
| development = false, | ||
| error = nil, | ||
| group = group, | ||
| _id = entry.request.id, |
There was a problem hiding this comment.
This is typically a UUID that we create in the client. I'm not seeing that done here, am I missing something?
There was a problem hiding this comment.
kong creates unique id, thats where this id is coming from
|
@erunion Thanks for the review, I fixed your issues. let me know if there is something else you want to see! |
Co-authored-by: Jon Ursenbach <[email protected]>
Co-authored-by: Jon Ursenbach <[email protected]>
🧰 Changes
Add kong plugin
🧬 QA & Testing
Follow the "Deploying locally" instructions in the PR