feat(dotnet, node, php, python): exclude OPTIONS requests from being logged #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gratcliff
requested changes
Aug 29, 2024
There was a problem hiding this comment.
@AndriiAndreiev can we add unit and integration tests for these changes?
| @@ -39,6 +42,9 @@ def before_request(self): | |||
| self.config.LOGGER.exception(e) | |||
|
|
|||
| def after_request(self, response): | |||
| if request.method == "OPTIONS": | |||
There was a problem hiding this comment.
Is it possible to get here in the request lifecycle when it's an OPTIONS call?
There was a problem hiding this comment.
@gratcliff @erunion i've added some tests for this feature and made some minor changes
AndriiAndreiev
changed the title
gratcliff
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Add a middleware checks for skipping OPTIONS requests