Skip to content

Commit

Permalink
chore(BREAKING): node 18 (#948)
Browse files Browse the repository at this point in the history
## 🧰 Changes

BREAKING CHANGE: Bumps the minimum required Node versions for all of our
Node packages.

By bumping to Node 18 (and therefore `npm@9`), we can also bump our NPM
lockfiles to `lockfileVersion@3` and remove a lot of duplicated
lockfiles in the process.

As part of this, our integration tests now `npm i` rather than `npm ci`
since there are no lockfiles in subdirectories for them to refer to.
This is probably an improvement in a way since this more closely matches
the dependency resolution approach our users would take.

## 🧬 QA & Testing

Does everything still pass?
  • Loading branch information
kanadgupta authored Jan 8, 2024
1 parent 36506cd commit c012cac
Show file tree
Hide file tree
Showing 18 changed files with 26 additions and 87,348 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/cloudflare-worker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@ jobs:
working-directory: packages/cloudflare-worker

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,9 @@ jobs:
working-directory: packages/node

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/snippets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@ jobs:
working-directory: packages/sdk-snippets

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20

Expand Down
Loading

0 comments on commit c012cac

Please sign in to comment.