Skip to content

Commit

Permalink
ci: lint PR titles, removes husky (#954)
Browse files Browse the repository at this point in the history
## 🧰 Changes

Lints PR titles so our release generation works properly! This feels
like a more robust check than husky, so I removed that as well.

## 🧬 QA & Testing

Confirmed locally that the VSCode GitHub Actions extension likes this ✅
  • Loading branch information
kanadgupta authored Jan 24, 2024
1 parent 5197475 commit 8cfb6d7
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 22 deletions.
19 changes: 19 additions & 0 deletions .github/workflows/lint-pr-title.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Lint PR Title

on:
pull_request_target:
types:
- opened
- edited

permissions:
pull-requests: read

jobs:
validate:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: amannn/action-semantic-pull-request@v5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4 changes: 0 additions & 4 deletions .husky/commit-msg

This file was deleted.

16 changes: 0 additions & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"clean": "npx lerna clean",
"lint": "eslint test/ && npm run lint --workspaces",
"lint:docs": "alex .",
"prepare": "husky install",
"prettier": "prettier --list-different \"./**/**.{js,ts,md}\"",
"prettier:write": "prettier --list-different --write \"./**/**.{js,ts,md}\"",
"publish": "npx lerna publish",
Expand Down Expand Up @@ -38,7 +37,6 @@
"form-data-encoder": "^2.1.0",
"formdata-node": "^5.0.0",
"har-validator": "^5.1.5",
"husky": "^8.0.3",
"isomorphic-fetch": "^3.0.0",
"prettier": "^3.0.2",
"vitest": "^0.34.2"
Expand Down

0 comments on commit 8cfb6d7

Please sign in to comment.