feat(api): addition of a new uninstall command #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kanad Gupta <[email protected]>
Co-authored-by: Kanad Gupta <[email protected]>
Co-authored-by: Kanad Gupta <[email protected]>
erunion
added
enhancement
erunion
commented
Oct 20, 2023
| @@ -45,6 +45,12 @@ | |||
| "sha512-ld+djZk8uRWmzXC+JYla1PTBScg0NjP/8x9vOOKRW+DuJ3NNMRjrpfbY7T77Jgnc87dZZsU49robbQfYe3ukug==" | |||
| ] | |||
| }, | |||
| "language": { | |||
There was a problem hiding this comment.
Keeping track of what language we generated the SDK for will allow us to know how to uninstall it from that languages package manager. And because this didn't exist before this we'll default to js everywhere we access this.
erunion
commented
Oct 20, 2023
| @@ -30,6 +30,7 @@ cmd | |||
| logger(`package name (${chalk.red('private')}): ${chalk.grey(`@api/${api.identifier}`)}`); | |||
| } | |||
|
|
|||
| logger(`language: ${chalk.grey(api.language || SupportedLanguages.JS)}`); | |||
erunion
commented
Oct 20, 2023
| @@ -226,30 +282,17 @@ export default class Storage { | |||
| } | |||
|
|
|||
| /** | |||
| * @example <caption>Storage directory structure</caption> | |||
There was a problem hiding this comment.
Removed this because I don't want to have to maintain it alongside the same tree in docs/how-it-works.md.
kanadgupta
reviewed
Oct 20, 2023
There was a problem hiding this comment.
sorry for all the feedback in this file — i definitely plan on doing a full comb through our docs before we release v7
| const entry = Storage.getFromLockfile(identifier); | ||
| if (!entry) { | ||
| logger( | ||
| `You do not appear to have ${identifier} installed. You can run \`npx api list\` to see what SDKs are present.`, |
Co-authored-by: Kanad Gupta <[email protected]>
Co-authored-by: Kanad Gupta <[email protected]>
Co-authored-by: Kanad Gupta <[email protected]>
Co-authored-by: Kanad Gupta <[email protected]>
kanadgupta
approved these changes
Oct 20, 2023
Co-authored-by: Kanad Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This creates a new
uninstallcommand that folks can use to uninstall codegen'd SDKs from their codebase. Not only will it runnpm uninstall @api/<identifier>it will also delete the generated SDK out of the.api/directory. Here's what it all looks like.