-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a placeholder README
file in codegen'd directory
#774
Merged
kanadgupta
merged 6 commits into
main
from
kanad/rm-8188-create-readmemd-in-codegend-directory
Oct 20, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a39612a
feat(codegen): add a placeholder README file
kanadgupta 17d7474
test: update fixtures
kanadgupta f4cace5
test(enhancement): add ability to create new files
kanadgupta 212b216
Merge branch 'main' into kanad/rm-8188-create-readmemd-in-codegend-di…
kanadgupta f4bc13e
Merge branch 'main' into kanad/rm-8188-create-readmemd-in-codegend-di…
kanadgupta 976c0fb
refactor: use storage for timestamp
kanadgupta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# `@api/alby` | ||
|
||
This SDK was autogenerated by the [`api` SDK generator](https://api.readme.dev), powered by [ReadMe](https://readme.com) 🦉 | ||
|
||
Add SDK setup information and usage examples here so your users get started in a jiffy! 🚀 | ||
|
||
<!--- | ||
Here's some additional info about the generated SDK: | ||
`api` version: <<package version>> | ||
Generated at 2023-01-01T00:00:00.000Z | ||
---> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# `@api/metrotransit` | ||
|
||
This SDK was autogenerated by the [`api` SDK generator](https://api.readme.dev), powered by [ReadMe](https://readme.com) 🦉 | ||
|
||
Add SDK setup information and usage examples here so your users get started in a jiffy! 🚀 | ||
|
||
<!--- | ||
Here's some additional info about the generated SDK: | ||
`api` version: <<package version>> | ||
Generated at 2023-01-01T00:00:00.000Z | ||
---> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# `@api/operationid-quirks` | ||
|
||
This SDK was autogenerated by the [`api` SDK generator](https://api.readme.dev), powered by [ReadMe](https://readme.com) 🦉 | ||
|
||
Add SDK setup information and usage examples here so your users get started in a jiffy! 🚀 | ||
|
||
<!--- | ||
Here's some additional info about the generated SDK: | ||
`api` version: <<package version>> | ||
Generated at 2023-01-01T00:00:00.000Z | ||
---> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# `@api/optional-payload` | ||
|
||
This SDK was autogenerated by the [`api` SDK generator](https://api.readme.dev), powered by [ReadMe](https://readme.com) 🦉 | ||
|
||
Add SDK setup information and usage examples here so your users get started in a jiffy! 🚀 | ||
|
||
<!--- | ||
Here's some additional info about the generated SDK: | ||
`api` version: <<package version>> | ||
Generated at 2023-01-01T00:00:00.000Z | ||
---> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# `@api/petstore` | ||
|
||
This SDK was autogenerated by the [`api` SDK generator](https://api.readme.dev), powered by [ReadMe](https://readme.com) 🦉 | ||
|
||
Add SDK setup information and usage examples here so your users get started in a jiffy! 🚀 | ||
|
||
<!--- | ||
Here's some additional info about the generated SDK: | ||
`api` version: <<package version>> | ||
Generated at 2023-01-01T00:00:00.000Z | ||
---> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# `@api/readme` | ||
|
||
This SDK was autogenerated by the [`api` SDK generator](https://api.readme.dev), powered by [ReadMe](https://readme.com) 🦉 | ||
|
||
Add SDK setup information and usage examples here so your users get started in a jiffy! 🚀 | ||
|
||
<!--- | ||
Here's some additional info about the generated SDK: | ||
`api` version: <<package version>> | ||
Generated at 2023-01-01T00:00:00.000Z | ||
---> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# `@api/response-title-quirks` | ||
|
||
This SDK was autogenerated by the [`api` SDK generator](https://api.readme.dev), powered by [ReadMe](https://readme.com) 🦉 | ||
|
||
Add SDK setup information and usage examples here so your users get started in a jiffy! 🚀 | ||
|
||
<!--- | ||
Here's some additional info about the generated SDK: | ||
`api` version: <<package version>> | ||
Generated at 2023-01-01T00:00:00.000Z | ||
---> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# `@api/simple` | ||
|
||
This SDK was autogenerated by the [`api` SDK generator](https://api.readme.dev), powered by [ReadMe](https://readme.com) 🦉 | ||
|
||
Add SDK setup information and usage examples here so your users get started in a jiffy! 🚀 | ||
|
||
<!--- | ||
Here's some additional info about the generated SDK: | ||
`api` version: <<package version>> | ||
Generated at 2023-01-01T00:00:00.000Z | ||
---> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# `@api/star-trek` | ||
|
||
This SDK was autogenerated by the [`api` SDK generator](https://api.readme.dev), powered by [ReadMe](https://readme.com) 🦉 | ||
|
||
Add SDK setup information and usage examples here so your users get started in a jiffy! 🚀 | ||
|
||
<!--- | ||
Here's some additional info about the generated SDK: | ||
`api` version: <<package version>> | ||
Generated at 2023-01-01T00:00:00.000Z | ||
---> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicating work in the
getFromLockfile
storage instance method but this whole storage class is really becoming a bit of a pain with its mix of instance and static methods. You don't have a great way of accessing an instance of `storage though here so it's fine.Maybe the whole storage class should just be refactored to be entirely static. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i noticed that
getFromLockfile
method but wasn't able to get it working without some deeper refactors 😮💨into this idea!