refactor: removing code formatting + upgrading to prettier 3 #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
commented
Aug 4, 2023
| @@ -1,5 +1,5 @@ | |||
| import type * as types from './types'; | |||
| import type { ConfigOptions, FetchResponse } from 'api/dist/core'; | |||
| import type { ConfigOptions, FetchResponse } from 'api/dist/core' | |||
There was a problem hiding this comment.
It's kinda funky that these type imports are no longer getting codegenerated with a ; but it seems like they do if there's three types being imported here. This might be resolved in the latest ts-morph releases, which we're a couple majors behind.
But since this code still works I'm not going to fret over it now.
kanadgupta
approved these changes
Aug 4, 2023
Co-authored-by: Kanad Gupta <[email protected]>
Co-authored-by: Kanad Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This upgrades our codebase to utilize Prettier 3. Unfortunately because Prettier 3 is now an ESM project, and though they still export CJS, I am having extreme troubles getting it working in our stack so I'm opting to remove it from our codegen SDKs where it was auto-formatting all code we generate.1
I would love to bring this back at some point because I think there's value in having a generated SDK that looks nice, but because these SDKs are still functional it's fine to remove it for now.
Footnotes
Having
prettier@3as a dependency inapiwas also causing problems with projects that are still usingprettier@2as NPM didn't like to have them installed alongside each other. ↩