fix: set TargetFramework to have default value (#98)

reactiveui · Jan 1, 2020 · d3759cd · d3759cd
1 parent 575cb8c
commit d3759cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Pharmacist.MsBuild.NuGet/PharmacistNuGetTask.cs b/src/Pharmacist.MsBuild.NuGet/PharmacistNuGetTask.cs
@@ -27,6 +27,8 @@ namespace Pharmacist.MsBuild.NuGet
     [SuppressMessage("Design", "CA1031: Catch specific exceptions", Justification = "Final logging location for exceptions.")]
     public class PharmacistNuGetTask : Task, IEnableLogger
     {
+        private const string DefaultTargetFramework = "netstandard2.0";
+
         private static readonly ISet<string> ExclusionPackageReferenceSet = new HashSet<string>(StringComparer.InvariantCultureIgnoreCase)
         {
             "Pharmacist.MSBuild",
@@ -42,8 +44,7 @@ public class PharmacistNuGetTask : Task, IEnableLogger
         /// <summary>
         /// Gets or sets the target framework.
         /// </summary>
-        [Required]
-        public string TargetFramework { get; set; }
+        public string TargetFramework { get; set; } = DefaultTargetFramework;
 
         /// <summary>
         /// Gets or sets the output file.
@@ -65,8 +66,7 @@ public override bool Execute()
 
             if (string.IsNullOrWhiteSpace(TargetFramework))
             {
-                Log.LogError($"{nameof(TargetFramework)} is not set");
-                return false;
+                TargetFramework = DefaultTargetFramework;
             }
 
             using (var writer = new StreamWriter(Path.Combine(OutputFile)))

diff --git a/version.json b/version.json
@@ -1,5 +1,5 @@
 {
-  "version": "1.3",
+  "version": "1.4",
   "publicReleaseRefSpec": [
     "^refs/heads/master$", // we release out of master
     "^refs/heads/develop$", // we release out of develop