Inherit link color in components using the Feedback color collection (#492) #565
Conversation
This change affects output HTML and may break downstream snapshot tests.
`Badge` color variants are now generated using color collections. Other components to be styled the same way already support theming, so `Badge` needs to support theming too. New theming options: `--rui-Badge--<PRIORITY>--<COLOR>__<PROPERTY>` See `theme.scss` for all available options.
src/styles/tools/_collections.scss
Outdated
| $color-category: _get-category-by-value($value: $variant-value, $collections: collections.$colors); | ||
|
|
||
| // 1. | ||
| // TODO: Figure out what to do with the `dark` color category where blue links do not work. |
There was a problem hiding this comment.
This seems to be an issue. As stated in #492, we want to keep the basic appearance for links inside components in the Neutral Light color. However, Neutral Dark is unreadable then.
I have to think about it yet. 🤔
There was a problem hiding this comment.
Personal opinion: Inherit color for neutral dark color (and keep only neutral light color) OR split link color property/ies between light and dark variant/s. This is beyond this discussion, but if we generally split colors between light and dark, couldn't we use it later for dark mode variant (which we haven't talk about it yet)?
There was a problem hiding this comment.
Light and dark colors (the neutral colors collection) and light and dark modes are something different. But if you mean we would face the same problem during dark mode design, you are probably right. Just with the difference that light and dark neutral colors will be both somewhat dark, just using a different shade of gray.
When I'm thinking about it from the design perspective, it makes sense to use the default link appearance in light color variants. Even if it means an exception in our code.
(Other way would be adding even more design tokens (= custom properties) which sounds like an overkill…)
There was a problem hiding this comment.
This is what I have now:
Apparently, links in the dark variant are undistinguishable from regular text 🙁. But this could be solved with advising to use underlined links (we don't have them yet) in this context.
There was a problem hiding this comment.
Maybe we can have another exception for Alerts where dark text would work well 😄
adamkudrna
force-pushed
the
refactor/use-color-collections
branch
from
69d7426
to
4c40045
Compare
See #492.