Skip to content

Commit

Permalink
Restrict React version to 18.2.x to prevent tests from failing due to…
Browse files Browse the repository at this point in the history
… deprecation warnings

Also, remove npm from "engines" as npm is not an engine.
  • Loading branch information
adamkudrna committed Aug 9, 2024
1 parent 3f6a0e2 commit e8cfbea
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 25 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/release-management.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@ name: Release Management

on:
push:
branches: [ master ]
# branches: [ master ]
branches: [ release/* ]

jobs:
test_and_build:
name: Test and build
runs-on: ubuntu-20.04
outputs:
tag: ${{ steps.check_package_version.outputs.version }}
version_changed: ${{ steps.check_package_version.outputs.changed }}
steps:
- name: Clone repository
Expand Down Expand Up @@ -71,11 +73,10 @@ jobs:
# `test_and_build` job first so this job is skipped rather than exited with an error.
- name: Publish matching GitHub release draft
id: github_release
uses: JamesMGreene/node-draft-releaser@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
allow_release_name_update: 'false'
GH_TOKEN: ${{ github.token }}
GH_REPO: ${{ github.repository }}
run: gh release edit "${{ needs.test_and_build.outputs.tag }}" --draft=false

- name: Write out the release URL
run: echo "Released at $RELEASE_URL"
Expand Down
35 changes: 19 additions & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
"url": "https://github.com/react-ui-org/react-ui"
},
"engines": {
"node": ">=20",
"npm": ">=10"
"node": ">=20"
},
"scripts": {
"build": "webpack --mode=production && webpack --mode=development",
Expand All @@ -54,8 +53,8 @@
},
"peerDependencies": {
"prop-types": "^15.8.0",
"react": "^18.0.0",
"react-dom": "^18.0.0"
"react": "~18.2.0",
"react-dom": "~18.2.0"
},
"devDependencies": {
"@babel/cli": "^7.24.7",
Expand Down Expand Up @@ -93,6 +92,8 @@
"postcss": "^8.4.39",
"postcss-loader": "^8.1.1",
"prop-types": "^15.8.1",
"react": "~18.2.0",
"react-dom": "~18.2.0",
"sass": "^1.77.6",
"sass-loader": "^14.2.1",
"stylelint": "^16.7.0",
Expand Down

0 comments on commit e8cfbea

Please sign in to comment.