Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed regression on Sky Titan stb #386

Closed
wants to merge 1 commit into from
Closed

Fixed regression on Sky Titan stb #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/platforms/browser/WebPlatform.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ export default class WebPlatform {
// Web-specific data types.
gl.texImage2D(gl.TEXTURE_2D, 0, options.internalFormat, options.format, options.type, source);
} else if (source instanceof HTMLCanvasElement) {
if (Utils.isZiggo) {
// Ziggo EOS and Selene have issues with getImageData implementation causing artifacts.
if (Utils.isZiggo || Utils.isSkyTitan) {
// Ziggo EOS, Ziggo Selene and Sky Titan Stbs have issues with getImageData implementation causing artifacts.
gl.texImage2D(gl.TEXTURE_2D, 0, options.internalFormat, options.format, options.type, source);
} else {
// Workaround for some browsers (e.g. Tizen) as they do not convert canvas data to texture correctly, sometimes causing artifacts.
Expand Down
1 change: 1 addition & 0 deletions src/tree/Utils.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,3 +196,4 @@ Utils.isSpark = (typeof sparkscene !== "undefined");
Utils.isNode = (typeof window === "undefined") || Utils.isSpark;
Utils.isPS4 = Utils.isWeb && (navigator.userAgent.indexOf("PlayStation 4") !== -1);
Utils.isZiggo = Utils.isWeb && (navigator.userAgent.indexOf("EOSSTB") !== -1 || navigator.userAgent.indexOf("HZNSTB") !== -1);
Utils.isSkyTitan = Utils.isWeb && (navigator.userAgent.indexOf("Sky, ES340") !== -1);