Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP 5.6, 5.5 and HHVM to travis.yml #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nyholm
Copy link

@Nyholm Nyholm commented Oct 10, 2014

No description provided.

@photodude
Copy link

photodude commented Jul 20, 2016

@Nyholm I would suggest making HHVM an allowed failure until the testing issues can be resolved.

You can also consider being LTS specific with HHVM as of may 2016

HHVM also has a php7 mode that can be tested against like this

- php: hhvm
      sudo: true
      dist: trusty
      group: edge # until the next update
      env: HHVMPHP7="no"
    - php: hhvm
      sudo: true
      dist: trusty
      group: edge # until the next update
      env: HHVMPHP7="yes
  allow_failures:
    - php: hhvm
before_script:
  - if [[ $HHVMPHP7 == "yes" ]]; then echo hhvm.php7.all=1 >> /etc/hhvm/php.ini; fi

Additionally, I would now also add PHP7.1 as an allowed failure

@Nyholm
Copy link
Author

Nyholm commented Jul 20, 2016

Im not too sure about the 'dist' property. I added more PHP versions and allow failures for hhvm

@photodude
Copy link

The 'dist' property just specifies Trusty as the image rather than precise (the specific ubuntu image used by travis ci)

The Trusty image is newer and has more testing options.

@photodude
Copy link

photodude commented Jul 20, 2016

I suggest the following

# Forces new Travis-CI Infrastructure for faster builds
sudo: false

language: php

matrix:
  fast_finish: true
  include:
    - php: 5.3
    - php: 5.4
    - php: 5.5
    - php: 5.6
    - php: 7.0
    - php: 7.1
    - php: hhvm
      sudo: true
      dist: trusty
      group: edge # until the next update
      env: HHVMPHP7="no"
    - php: hhvm
      sudo: true
      dist: trusty
      group: edge # until the next update
      env: HHVMPHP7="yes
  allow_failures:
    - php: hhvm

before_script:
  - if [[ $HHVMPHP7 == "yes" ]]; then echo hhvm.php7.all=1 >> /etc/hhvm/php.ini; fi

script:
  - phpunit

without the env: variable HHVM will not run in php7 mode

@Nyholm
Copy link
Author

Nyholm commented Jul 20, 2016

That is an invalid config.
https://lint.travis-ci.org/

@photodude
Copy link

@Nyholm Check the spacing, I probably copied too many spaces when I cut and pasted from several things to get that config.

I replaced it with the space indenting fixed, should work now

@photodude
Copy link

@Nyholm can you try the updated change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants