Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sslscan target non-phony #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjlin
Copy link

@jjlin jjlin commented Mar 17, 2016

Since sslscan is a real file, it should be removed from the .PHONY list
so that make static install won't try to build a non-static version.

@jjlin
Copy link
Author

jjlin commented Mar 31, 2016

Any particular reason you haven't merged this yet? In #68, you wrote:

Doing it in bash seems like a bit of an ugly fix, but I couldn't see a nice way to do the check natively in the Makefile

Making sslscan a non-phony target and letting make create that file as necessary is how that check is done natively.

@rbsec
Copy link
Owner

rbsec commented Apr 3, 2016

The sslscan target was originally marked at as pnony in the PR that introduced static building. The problem with marking it as non-phony is that it means that if (for example), you run make, then if you run a make static it will see that sslscan already exists so won't rebuild it (so you'll still have the dynamically build version), which isn't desirible. It's a pain if you have to keep running make clean, because that also blows away the compiled OpenSSL stuff.

I needd to see if there's a nice way to allow both make and make static to work properly with a non-phony sslscan - although I have a feeling it will involve some more ugly bash code :/

~rbsec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants