-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CEPF-1750]: Added fetch payment methods endpoint #329
Conversation
@@ -122,4 +122,7 @@ public Payment validateUpi(JSONObject request) throws RazorpayException { | |||
public Payment expandedDetails(String id, JSONObject request) throws RazorpayException { | |||
return get(Constants.VERSION, String.format(Constants.PAYMENT_GET, id), request); | |||
} | |||
public Methods fetchPaymentMethods() throws RazorpayException { | |||
return get(Constants.VERSION, Constants.FETCH_PAYMENT_METHODS, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename constant FETCH_PAYMENT_METHODS to METHODS to keep it generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed constant FETCH_PAYMENT_METHODS
to METHODS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
============================================
+ Coverage 82.15% 82.17% +0.02%
- Complexity 332 333 +1
============================================
Files 64 64
Lines 762 763 +1
Branches 34 34
============================================
+ Hits 626 627 +1
Misses 111 111
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Doc reference
Fetch payment methods