Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CEPF-1750]: Added fetch payment methods endpoint #329

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

ankitdas13
Copy link
Contributor

@ankitdas13 ankitdas13 commented Oct 18, 2024

Doc reference

Fetch payment methods

@@ -122,4 +122,7 @@ public Payment validateUpi(JSONObject request) throws RazorpayException {
public Payment expandedDetails(String id, JSONObject request) throws RazorpayException {
return get(Constants.VERSION, String.format(Constants.PAYMENT_GET, id), request);
}
public Methods fetchPaymentMethods() throws RazorpayException {
return get(Constants.VERSION, Constants.FETCH_PAYMENT_METHODS, null);
Copy link

@dhruvgolani28 dhruvgolani28 Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename constant FETCH_PAYMENT_METHODS to METHODS to keep it generic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed constant FETCH_PAYMENT_METHODS to METHODS

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (524cd70) to head (aa29fc1).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #329      +/-   ##
============================================
+ Coverage     82.15%   82.17%   +0.02%     
- Complexity      332      333       +1     
============================================
  Files            64       64              
  Lines           762      763       +1     
  Branches         34       34              
============================================
+ Hits            626      627       +1     
  Misses          111      111              
  Partials         25       25              
Flag Coverage Δ
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@dhruvgolani28 dhruvgolani28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitdas13 ankitdas13 added the TestingNotRequired TestingNotRequired label for BVT label Oct 22, 2024
@ankitdas13 ankitdas13 merged commit a4aec2a into master Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TestingNotRequired TestingNotRequired label for BVT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants